Add foreach Assignment to AvoidAssignmentToAutomaticVariable - #2021
Merged
Conversation
AJ Raymond (poshAJ)
changed the title
AJ Raymond (poshAJ)
force-pushed
the
main
branch
from
August 10, 2024 22:44
62b38f3 to
184835f
Compare
James Truher (JamesWTruher)
requested review from
James Truher (JamesWTruher) and
Christoph Bergmeister (bergmeister)
August 14, 2024 17:17
Christoph Bergmeister (bergmeister)
approved these changes
Feb 17, 2025
Christoph Bergmeister (bergmeister)
left a comment
Christoph Bergmeister (bergmeister)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
AJ Raymond (poshAJ)
force-pushed
the
main
branch
from
February 24, 2025 00:30
4e74f3f to
7cf4013
Compare
AJ Raymond (poshAJ)
requested a review
from Andy Jordan (andyleejordan)
as a code owner
February 24, 2025 00:30
Andy Jordan (andyleejordan)
approved these changes
Feb 25, 2025
Andy Jordan (andyleejordan)
left a comment
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
Looks great to me, nice fix, thank you.
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
February 25, 2025 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #2020
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.